Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonical zh-cn text #4214

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Jan 20, 2022

What's the purpose of this PR

Which issue(s) this PR fixes:

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #4214 (497e1c6) into master (c5206d5) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4214      +/-   ##
============================================
+ Coverage     52.55%   52.57%   +0.02%     
  Complexity     2630     2630              
============================================
  Files           485      485              
  Lines         15225    15225              
  Branches       1573     1573              
============================================
+ Hits           8001     8005       +4     
+ Misses         6667     6663       -4     
  Partials        557      557              
Impacted Files Coverage Δ
...ework/apollo/internals/RemoteConfigRepository.java 87.73% <0.00%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5206d5...497e1c6. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 79d9005 into apolloconfig:master Jan 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants