Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: associated namespace parse text incorrect #4219

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

darcydai
Copy link
Contributor

@darcydai darcydai commented Jan 26, 2022

What's the purpose of this PR

  1. associated namespace parse text incorrect because of field publicNamespace.isPropertiesFormat not set

Which issue(s) this PR fixes:

Fixes #
As below
image

image

Brief changelog

associated namespace display in text incorrect

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Jan 26, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Please also update the CHANGES.md and sign the CLA.

darcydai and others added 2 commits January 26, 2022 13:58
…space-panel-directive.js

Co-authored-by: Jason Song <nobodyiam@gmail.com>
@darcydai
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@darcydai
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@darcydai darcydai requested a review from nobodyiam January 27, 2022 06:03
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ced8ad9 into apolloconfig:master Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants