Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using commons-lang3 to replace commons-lang #4225

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

ruanwenjun
Copy link
Contributor

@ruanwenjun ruanwenjun commented Feb 11, 2022

What's the purpose of this PR

  1. It's better to use commons-lang3 rather than commons-lang, since commons-lang is deprecated.
  2. It's better to use org.apache.commons.lang3.SystemUtils to judge the system, this utils is more reliable.

Which issue(s) this PR fixes:

no

Brief changelog

  • Using commons-lang3 to replace commons-lang
  • Using org.apache.commons.lang3.SystemUtils to judge is Window.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Feb 11, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_usingLang3 branch from 09f032d to 59a7ec7 Compare February 11, 2022 04:30
@ruanwenjun
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I think it's okay to upgrade commons-lang to commons-lang3 for apollo servers but it seems to me unnecessary to add an extra dependency to apollo-core which will impact a lot of users.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_usingLang3 branch from 82d47d6 to e5a2763 Compare February 13, 2022 11:29
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_usingLang3 branch from 8a8d1f3 to ee7d9f7 Compare February 14, 2022 10:45
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4225 (8af33cf) into master (9d27eb8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4225      +/-   ##
============================================
- Coverage     52.58%   52.56%   -0.02%     
- Complexity     2631     2632       +1     
============================================
  Files           486      486              
  Lines         15226    15226              
  Branches       1573     1573              
============================================
- Hits           8006     8003       -3     
- Misses         6664     6668       +4     
+ Partials        556      555       -1     
Impacted Files Coverage Δ
...mework/apollo/common/utils/UniqueKeyGenerator.java 0.00% <ø> (ø)
...mework/apollo/openapi/service/ConsumerService.java 55.08% <ø> (ø)
...ponent/emailbuilder/ConfigPublishEmailBuilder.java 1.83% <ø> (ø)
...llo/portal/controller/ConfigsExportController.java 18.51% <ø> (ø)
...mework/apollo/portal/spi/ldap/LdapUserService.java 0.00% <ø> (ø)
...amework/apollo/portal/util/RelativeDateFormat.java 0.00% <ø> (ø)
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️
...work/apollo/biz/message/ReleaseMessageScanner.java 82.89% <0.00%> (-2.64%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d27eb8...8af33cf. Read the comment docs.

@nobodyiam nobodyiam merged commit a9579f1 into apolloconfig:master Feb 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_usingLang3 branch March 16, 2022 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants