-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using commons-lang3 to replace commons-lang #4225
Using commons-lang3 to replace commons-lang #4225
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
09f032d
to
59a7ec7
Compare
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I think it's okay to upgrade commons-lang to commons-lang3 for apollo servers but it seems to me unnecessary to add an extra dependency to apollo-core which will impact a lot of users.
apollo-core/src/main/java/com/ctrip/framework/foundation/internals/Utils.java
Outdated
Show resolved
Hide resolved
apollo-core/src/test/java/com/ctrip/framework/foundation/internals/UtilsTest.java
Outdated
Show resolved
Hide resolved
82d47d6
to
e5a2763
Compare
apollo-core/src/test/java/com/ctrip/framework/foundation/internals/UtilsTest.java
Outdated
Show resolved
Hide resolved
8a8d1f3
to
ee7d9f7
Compare
ee7d9f7
to
8af33cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #4225 +/- ##
============================================
- Coverage 52.58% 52.56% -0.02%
- Complexity 2631 2632 +1
============================================
Files 486 486
Lines 15226 15226
Branches 1573 1573
============================================
- Hits 8006 8003 -3
- Misses 6664 6668 +4
+ Partials 556 555 -1
Continue to review full report at Codecov.
|
What's the purpose of this PR
commons-lang3
rather thancommons-lang
, sincecommons-lang
is deprecated.org.apache.commons.lang3.SystemUtils
to judge the system, this utils is more reliable.Which issue(s) this PR fixes:
no
Brief changelog
commons-lang3
to replacecommons-lang
org.apache.commons.lang3.SystemUtils
to judge is Window.Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.