Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import config bug #4262

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Mar 11, 2022

What's the purpose of this PR

Which issue(s) this PR fixes:

  1. fix cover existed app when importing app
  2. fix import cluster info to all envs when importing cluster

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

2. fix import cluster info to all envs when importing cluster
@lepdou lepdou force-pushed the dev/lepdou/fix_import_export2 branch from 1c980e3 to e52431f Compare March 11, 2022 11:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #4262 (e52431f) into master (0ae4fc7) will decrease coverage by 0.00%.
The diff coverage is 64.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4262      +/-   ##
============================================
- Coverage     52.59%   52.59%   -0.01%     
  Complexity     2632     2632              
============================================
  Files           486      486              
  Lines         15221    15232      +11     
  Branches       1572     1572              
============================================
+ Hits           8006     8011       +5     
- Misses         6660     6666       +6     
  Partials        555      555              
Impacted Files Coverage Δ
...ip/framework/apollo/portal/service/AppService.java 15.66% <0.00%> (-0.20%) ⬇️
...rk/apollo/portal/service/ConfigsImportService.java 73.41% <66.66%> (-1.48%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (-0.61%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...o/openapi/filter/ConsumerAuthenticationFilter.java 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae4fc7...e52431f. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 4c7ab93 into apolloconfig:master Mar 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants