Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom define discovery #4266

Merged

Conversation

gy09535
Copy link
Contributor

@gy09535 gy09535 commented Mar 14, 2022

Which issue(s) this PR fixes:

Fixes #4259

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@gy09535
Copy link
Contributor Author

gy09535 commented Mar 14, 2022

according to #4260

@nobodyiam
Copy link
Member

Thanks, would you please also add some instructions so that other users could know how to use this discovery mode? we may put it after zookeeper discovery in distributed-deployment-guide.

@gy09535
Copy link
Contributor Author

gy09535 commented Mar 15, 2022

Thanks, would you please also add some instructions so that other users could know how to use this discovery mode? we may put it after zookeeper discovery in distributed-deployment-guide.

added

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit eb78ceb into apolloconfig:master Mar 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add self define meta server
2 participants