Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JUnit. Fixes #3874 #4271

Merged
merged 8 commits into from
Mar 25, 2022
Merged

Conversation

ayush0407
Copy link
Contributor

What's the purpose of this PR

This PR is for JUnit fix and increased coverage and logic test.

XXXXX

Which issue(s) this PR fixes:

Fixes #3874

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, would you please follow the code style to format these 2 files?

BTW, the new file need to have the copyright comment in its header.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #4271 (5032560) into master (672320f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4271      +/-   ##
============================================
+ Coverage     52.56%   52.58%   +0.02%     
- Complexity     2635     2641       +6     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
+ Hits           8017     8021       +4     
+ Misses         6682     6681       -1     
+ Partials        554      551       -3     
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
...ework/apollo/spring/util/BeanRegistrationUtil.java 91.66% <0.00%> (+4.16%) ⬆️
...k/apollo/biz/utils/ConfigChangeContentBuilder.java 100.00% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672320f...5032560. Read the comment docs.

@ayush0407
Copy link
Contributor Author

Thanks for the contribution, would you please follow the code style to format these 2 files?

BTW, the new file need to have the copyright comment in its header.

Sure, I'll fix that and check in the code.

@ayush0407
Copy link
Contributor Author

Hi there, I added the copyright statement in the new file but can you please help me with the code format. I didn't get that part?

@nobodyiam
Copy link
Member

@ayush0407

According to the Code Conventions, you need to import the code style files into your IDE, and use that to format your code changes.
If you don't use any IDE, then you may manually format the code changes, e.g. indent size is 2, tab size is 2, use space to replace tab, etc.

image

zouyx
zouyx previously approved these changes Mar 21, 2022
@zouyx zouyx dismissed their stale review March 21, 2022 14:33

dismiss

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test case pls

@ayush0407
Copy link
Contributor Author

Fix test case pls

Which one specifically? Is any of the test breaking?

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 8d623d5 into apolloconfig:master Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: improve coverage
4 participants