-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JUnit. Fixes #3874 #4271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, would you please follow the code style to format these 2 files?
BTW, the new file need to have the copyright comment in its header.
Codecov Report
@@ Coverage Diff @@
## master #4271 +/- ##
============================================
+ Coverage 52.56% 52.58% +0.02%
- Complexity 2635 2641 +6
============================================
Files 488 488
Lines 15253 15253
Branches 1577 1577
============================================
+ Hits 8017 8021 +4
+ Misses 6682 6681 -1
+ Partials 554 551 -3
Continue to review full report at Codecov.
|
Sure, I'll fix that and check in the code. |
Hi there, I added the copyright statement in the new file but can you please help me with the code format. I didn't get that part? |
According to the Code Conventions, you need to import the code style files into your IDE, and use that to format your code changes. |
...lo-client/src/test/java/com/ctrip/framework/apollo/spring/util/BeanRegistrationUtilTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test case pls
...o-biz/src/test/java/com/ctrip/framework/apollo/biz/utils/ConfigChangeContentBuilderTest.java
Outdated
Show resolved
Hide resolved
Which one specifically? Is any of the test breaking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
This PR is for JUnit fix and increased coverage and logic test.
XXXXX
Which issue(s) this PR fixes:
Fixes #3874
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.