Test coverage #4280
Merged
Test coverage #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4280 +/- ##
============================================
+ Coverage 52.56% 53.12% +0.56%
- Complexity 2641 2666 +25
============================================
Files 488 488
Lines 15253 15253
Branches 1577 1577
============================================
+ Hits 8017 8103 +86
+ Misses 6685 6593 -92
- Partials 551 557 +6
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Mar 27, 2022
| public void testMapByKeyEmptyList() { | ||
| List<Integer> someList = new ArrayList<>(); | ||
| assertNotNull(BeanUtils.mapByKey(null, someList)); | ||
|
|
| List<KeyClass> someList = new ArrayList<>(); | ||
| someList.add(new KeyClass()); | ||
| assertNotNull(BeanUtils.mapByKey("keys", someList)); | ||
|
|
| List<KeyClass> someList = new ArrayList<>(); | ||
| someList.add(new KeyClass()); | ||
| assertNotNull(BeanUtils.mapByKey("wrongKey", someList)); | ||
|
|
| public void testAggByKeyToListEmpty() { | ||
| List<KeyClass> someList = new ArrayList<>(); | ||
| assertNotNull(BeanUtils.aggByKeyToList("keys", someList)); | ||
|
|
| List<KeyClass> someList = new ArrayList<>(); | ||
| someList.add(new KeyClass()); | ||
| assertNotNull(BeanUtils.aggByKeyToList("keys", someList)); | ||
|
|
| public void testToPropertySetEmpty() { | ||
| List<KeyClass> someList = new ArrayList<>(); | ||
| assertNotNull(BeanUtils.toPropertySet("keys", someList)); | ||
|
|
| List<KeyClass> someList = new ArrayList<>(); | ||
| someList.add(new KeyClass()); | ||
| assertNotNull(BeanUtils.toPropertySet("keys", someList)); | ||
|
|
| List<KeyClass> someList = new ArrayList<>(); | ||
| someList.add(new KeyClass()); | ||
| assertNotNull(BeanUtils.toPropertySet("wrongKey", someList)); | ||
|
|
| public void testGetAndsetProperty() { | ||
| BeanUtils.setProperty(new KeyClass(), "keys", "value"); | ||
| assertNull(BeanUtils.getProperty(new KeyClass(), "keys")); | ||
|
|
Comment on lines
143
to
145
|
|
||
|
|
||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
This PR increases the JUnit coverage and also test's out the classes involved.
XXXXX
Which issue(s) this PR fixes:
Fixes #3874
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.