-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mysql-connector-java version to fix possible transaction rollback failure issue #4425
Conversation
# Conflicts: # README.md
Codecov Report
@@ Coverage Diff @@
## master #4425 +/- ##
============================================
- Coverage 53.41% 53.39% -0.02%
- Complexity 2686 2687 +1
============================================
Files 490 490
Lines 15254 15254
Branches 1586 1586
============================================
- Hits 8148 8145 -3
- Misses 6548 6552 +4
+ Partials 558 557 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nobodyiam |
I don't know much about the protocol rules, but I see that spring-boot and skywalking also have this dependency, and they are both open source projects for the Apache protocol. So, it shouldn't be a big problem. No other questions then, I'll merge it in first |
What's the purpose of this PR
There is a known bug in mysql-connector-java:8.0.28 that prevents transaction rollback when useLocalSessionState=true. apollo does not disallow users to set mysql link parameters, so there may be a potential problem
This bug was fixed in mysql-connector-java:8.0.29
Reference: https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/news-8-0-29.html