Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mysql-connector-java version to fix possible transaction rollback failure issue #4425

Merged
merged 33 commits into from
Jun 22, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jun 21, 2022

What's the purpose of this PR

There is a known bug in mysql-connector-java:8.0.28 that prevents transaction rollback when useLocalSessionState=true. apollo does not disallow users to set mysql link parameters, so there may be a potential problem

image

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from Anilople June 21, 2022 06:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #4425 (ef71351) into master (7d25d55) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4425      +/-   ##
============================================
- Coverage     53.41%   53.39%   -0.02%     
- Complexity     2686     2687       +1     
============================================
  Files           490      490              
  Lines         15254    15254              
  Branches       1586     1586              
============================================
- Hits           8148     8145       -3     
- Misses         6548     6552       +4     
+ Partials        558      557       -1     
Impacted Files Coverage Δ
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-2.46%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.44% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d25d55...ef71351. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoothzj
Copy link
Member

@nobodyiam mysql-connector-java is under GPL 2.0 license. Can we use it directly?

@klboke
Copy link
Contributor Author

klboke commented Jun 22, 2022

I don't know much about the protocol rules, but I see that spring-boot and skywalking also have this dependency, and they are both open source projects for the Apache protocol. So, it shouldn't be a big problem. No other questions then, I'll merge it in first

@klboke klboke merged commit 66374a1 into apolloconfig:master Jun 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants