Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:user manage #4445

Closed
wants to merge 13 commits into from
Closed

Conversation

falser101
Copy link
Member

Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io

What's the purpose of this PR

feature: user manage

Which issue(s) this PR fixes:

Fixes # #4294

Brief changelog

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

falser101 and others added 13 commits July 3, 2022 21:59
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
@falser101 falser101 changed the title Feature/users feature:user manage Jul 5, 2022
@falser101
Copy link
Member Author

falser101 commented Jul 5, 2022

user listimage
add or edit user image
@nobodyiam please help review thanks

@codecov-commenter
Copy link

Codecov Report

Merging #4445 (cc41aea) into master (804ffae) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4445      +/-   ##
============================================
+ Coverage     53.38%   53.39%   +0.01%     
  Complexity     2688     2688              
============================================
  Files           490      490              
  Lines         15252    15257       +5     
  Branches       1586     1586              
============================================
+ Hits           8142     8147       +5     
- Misses         6553     6554       +1     
+ Partials        557      556       -1     
Impacted Files Coverage Δ
...ip/framework/apollo/portal/entity/bo/UserInfo.java 52.17% <0.00%> (-7.83%) ⬇️
...trip/framework/apollo/portal/entity/po/UserPO.java 28.00% <0.00%> (-1.17%) ⬇️
.../spi/springsecurity/SpringSecurityUserService.java 0.00% <0.00%> (ø)
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804ffae...cc41aea. Read the comment docs.

@nobodyiam
Copy link
Member

@falser101

It's really nice of you to submit this pull request and it looks great to me!
However, #4294 was assigned to a student in ospp program 2022. I hope the community could give the student some time to complete this feature.
I'm sorry for not updating the issue status promptly and I just did a quick update and they are up-to-date now.

@falser101
Copy link
Member Author

@falser101

It's really nice of you to submit this pull request and it looks great to me! However, #4294 was assigned to a student in ospp program 2022. I hope the community could give the student some time to complete this feature. I'm sorry for not updating the issue status promptly and I just did a quick update and they are up-to-date now.

i'm ok! I'll do something else

@falser101 falser101 closed this Jul 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
@falser101 falser101 deleted the feature/users branch July 12, 2022 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants