Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify filter user #4562

Merged
merged 24 commits into from
Sep 9, 2022
Merged

Modify filter user #4562

merged 24 commits into from
Sep 9, 2022

Conversation

zcy1010
Copy link
Contributor

@zcy1010 zcy1010 commented Sep 9, 2022

What's the purpose of this PR

modify filter user button

Which issue(s) this PR fixes:

Fixes #4294

Brief changelog

Modify the user management interface layout

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@zcy1010
Copy link
Contributor Author

zcy1010 commented Sep 9, 2022

@nobodyiam Please help me review the code :D

@codecov-commenter
Copy link

Codecov Report

Merging #4562 (93ad8a2) into master (cb62807) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4562      +/-   ##
============================================
- Coverage     53.28%   53.26%   -0.02%     
+ Complexity     2705     2703       -2     
============================================
  Files           494      494              
  Lines         15416    15416              
  Branches       1599     1599              
============================================
- Hits           8215     8212       -3     
- Misses         6641     6642       +1     
- Partials        560      562       +2     
Impacted Files Coverage Δ
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <0.00%> (-5.41%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.84% <0.00%> (-0.60%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 70791c8 into apolloconfig:master Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A user-friendly user management page for apollo portal
3 participants