Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-Database Support] package postgre h2 dependency] #4763

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Mar 2, 2023

What's the purpose of this PR

To support multi database, package postgreh2 dependency in package.

Brief changelog

Add postgreh2 in the apollo-common pom.xml

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #4763 (0b84512) into master (a76521e) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4763      +/-   ##
============================================
+ Coverage     47.27%   47.32%   +0.05%     
- Complexity     1655     1659       +4     
============================================
  Files           346      346              
  Lines         10662    10662              
  Branches       1058     1058              
============================================
+ Hits           5040     5046       +6     
+ Misses         5316     5309       -7     
- Partials        306      307       +1     
Impacted Files Coverage Δ
...m/ctrip/framework/apollo/biz/entity/AccessKey.java 58.33% <ø> (ø)
...a/com/ctrip/framework/apollo/biz/entity/Audit.java 52.94% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Cluster.java 58.82% <ø> (ø)
.../com/ctrip/framework/apollo/biz/entity/Commit.java 5.55% <ø> (ø)
...p/framework/apollo/biz/entity/GrayReleaseRule.java 100.00% <ø> (ø)
...va/com/ctrip/framework/apollo/biz/entity/Item.java 86.36% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Namespace.java 61.11% <ø> (ø)
...rip/framework/apollo/biz/entity/NamespaceLock.java 25.00% <ø> (ø)
...m/ctrip/framework/apollo/biz/entity/Privilege.java 8.33% <ø> (ø)
...com/ctrip/framework/apollo/biz/entity/Release.java 82.14% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants