Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: openapi 3.2.17 Create App And grant administrative privileges #5046

Merged
merged 7 commits into from
Dec 22, 2023

Conversation

Anilople
Copy link
Contributor

What's the purpose of this PR

Add document of openapi app creation.

Which issue(s) this PR fixes:

Fixes #4954 (comment)

Brief changelog

3.2.17 Create App And grant administrative privileges

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cea083) 49.62% compared to head (60255f7) 49.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5046      +/-   ##
============================================
+ Coverage     49.62%   49.66%   +0.03%     
- Complexity     1904     1906       +2     
============================================
  Files           372      372              
  Lines         11558    11558              
  Branches       1127     1127              
============================================
+ Hits           5736     5740       +4     
+ Misses         5482     5478       -4     
  Partials        340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nobodyiam nobodyiam force-pushed the docs/openapi-create-app branch from 32d33b8 to 84600a1 Compare December 17, 2023 13:15

App can be created through this interface,

> note: 需要在创建第三方应用时,**勾选允许创建app,否则会触发异常,HTTP状态码401**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> note: 需要在创建第三方应用时,**勾选允许创建app,否则会触发异常,HTTP状态码401**

Should this line be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to prompt user, some users maybe use 'old token' to call this openapi method and get the failed result.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur. My suggestion is to remove the line in Chinese since it's already duplicated in English below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. Remove it already.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 22, 2023
@nobodyiam nobodyiam merged commit 31f3082 into apolloconfig:master Dec 22, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants