-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: openapi 3.2.17 Create App And grant administrative privileges #5046
docs: openapi 3.2.17 Create App And grant administrative privileges #5046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5046 +/- ##
============================================
+ Coverage 49.62% 49.66% +0.03%
- Complexity 1904 1906 +2
============================================
Files 372 372
Lines 11558 11558
Branches 1127 1127
============================================
+ Hits 5736 5740 +4
+ Misses 5482 5478 -4
Partials 340 340 ☔ View full report in Codecov by Sentry. |
32d33b8
to
84600a1
Compare
|
||
App can be created through this interface, | ||
|
||
> note: 需要在创建第三方应用时,**勾选允许创建app,否则会触发异常,HTTP状态码401** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> note: 需要在创建第三方应用时,**勾选允许创建app,否则会触发异常,HTTP状态码401** |
Should this line be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to prompt user, some users maybe use 'old token' to call this openapi method and get the failed result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur. My suggestion is to remove the line in Chinese since it's already duplicated in English below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault. Remove it already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Add document of openapi app creation.
Which issue(s) this PR fixes:
Fixes #4954 (comment)
Brief changelog
3.2.17 Create App And grant administrative privileges
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.