Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular references on LdapAutoConfiguration #5055

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Fix circular references on LdapAutoConfiguration #5055

merged 3 commits into from
Dec 21, 2023

Conversation

BlackBear2003
Copy link
Contributor

@BlackBear2003 BlackBear2003 commented Dec 19, 2023 •
edited
Loading

What's the purpose of this PR

Fix circular references on LdapAutoConfiguration

Which issue(s) this PR fixes:

Fixes ##5051

Brief changelog

Update SpringSecurityLDAPAuthAutoConfiguration

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76ec52d) 49.62% compared to head (33b9ab7) 49.62%.

Files Patch % Lines
...lo/portal/spi/configuration/AuthConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5055   +/-   ##
=========================================
  Coverage     49.62%   49.62%           
  Complexity     1904     1904           
=========================================
  Files           372      372           
  Lines         11559    11558    -1     
  Branches       1127     1127           
=========================================
  Hits           5736     5736           
+ Misses         5483     5482    -1     
  Partials        340      340

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackBear2003
Copy link
Contributor Author

Can I not write test code for this PR please?🥺

@BlackBear2003 BlackBear2003 changed the base branch from master to dependabot/maven/com.google.guava-guava-32.0.0-jre December 19, 2023 13:30
@BlackBear2003 BlackBear2003 changed the base branch from dependabot/maven/com.google.guava-guava-32.0.0-jre to master December 19, 2023 13:33
@nobodyiam
Copy link
Member

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests.
Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

@BlackBear2003
Copy link
Contributor Author

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests. Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

Am I update on the right CHANGES file?

nobodyiam
nobodyiam reviewed Dec 21, 2023
View reviewed changes
changes/changes-2.2.0.md Outdated
@@ -31,6 +31,7 @@ Apollo 2.2.0
* [Fix the issue that namespace content being cleared when identical content is pasted into the namespace](https://github.com/apolloconfig/apollo/pull/4922)
* [feat(openapi): allow user create app via openapi](https://github.com/apolloconfig/apollo/pull/4954)
* [Support grayscale feature for non-properties namespaces](https://github.com/apolloconfig/apollo/pull/4952)
* [Fix circular references on LdapAutoConfiguration](https://github.com/apolloconfig/apollo/pull/5055)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.2.0 was released. Please add the change to the https://github.com/apolloconfig/apollo/blob/master/CHANGES.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.2.0 was released. Please add the change to the https://github.com/apolloconfig/apollo/blob/master/CHANGES.md

added😃

nobodyiam
nobodyiam approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 21, 2023
@nobodyiam nobodyiam merged commit 1cea083 into apolloconfig:master Dec 21, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BlackBear2003 @nobodyiam