-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment for clusters and UI display #5072
Add comment for clusters and UI display #5072
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
============================================
- Coverage 49.65% 49.60% -0.06%
+ Complexity 1905 1904 -1
============================================
Files 372 372
Lines 11558 11564 +6
Branches 1127 1127
============================================
- Hits 5739 5736 -3
- Misses 5478 5488 +10
+ Partials 341 340 -1 ☔ View full report in Codecov by Sentry. |
This looks great! Please find some comments below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Below are a few comments for your consideration. Additionally, please update the CHANGES.md file to inform users about this new feature.
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/entity/Cluster.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Add comment for clusters and UI display
Which issue(s) this PR fixes:
Fixes ##5067
Brief changelog
it looks like:
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.