Fix issue where cache updates would not cause rerenders in useSuspenseQuery while in strict mode

[jerelmiller]

Closes #10428

Fixes an issue where using useSuspenseQuery would not react to cache updates while using React's strict mode.

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

⚠️ No Changeset found

Latest commit: 44985b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[jerelmiller]

/release:pr

[github-actions]

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10601-20230224210620.

[jerelmiller]

I can confirm this PR fixes the issue using the snapshot release.

To test using the Spotify demo:

• Enable strict mode by uncommenting the <StrictMode /> wrapper in client/src/index.tsx
• Start playing a song
• Like/unlike the song in the playbar using the heart icon

When on the latest alpha version, you'll notice the hear icon is not properly updated to reflect the change made. The heart should toggle on/off when liking/unliking the track but this does not occur. Using the snapshot release, perform the same process again and you'll notice the heart icon is now properly updated.

[alessbell]

I agree with the case being made for this workaround—which the comment lays out very clearly 😄—and the strictMode option will make it straightforward to add tests for these scenarios in the future 🎉

As an aside, it looks like nearly all tests still pass with strictMode: true, with only the suspenseCount assertions needing adjusting for obvious reasons. allows the client to be overridden and uses default variables from the client when none provided in options, however, look like they would either a) need further consideration or b) potentially be an indicator of a strict mode issue we should look at more closely - @jerelmiller just flagging these two tests since you surely have more insight here 👍

[alessbell]

🥲

[jerelmiller]

Ya......................................................

[jerelmiller]

@alessbell good callout. I'm going to try those tests with a strict mode variant and ensure they work as expected.

[jerelmiller]

@alessbell I've added tests for the 2 you called out, each using strict mode: 7277274 and 44985b8. Just to confirm, do these tests satisfy what you're looking to answer, or is there something further I can test?

[alessbell]

@jerelmiller thanks! Yes, that answers it perfectly 🙏

[jerelmiller]

arghhhhh. I forgot to create a changeset for this branch. I'll create a separate PR that links to this one.