-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate experimental testing utilities #11930
Deprecate experimental testing utilities #11930
Conversation
🦋 Changeset detectedLatest commit: 3fa3eb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@alessbell would love your thoughts here. Also, what would we like to do with the schema driven testing doc? Do we want to add a note to the top of that with a similar deprecation warning? Or should we rewrite that for 3.11 to switch over to graphql-testing-library? |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -50,6 +50,8 @@ interface TestSchemaOptions { | |||
* ``` | |||
* @since 3.9.0 | |||
* @alpha | |||
* @deprecated `createTestSchema` is deprecated and will be removed in 3.12.0. | |||
* Please migrate to [`graphql-testing-library`](https://github.com/apollographql/graphql-testing-library). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want the repo name here or the npm package name which is @apollo/graphql-testing-library
. I have a slight preference for the latter but either works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout! I agree, the package name seems more reasonable. I've updated it with 7b6c071. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening this! Left one minor comment but this LGTM 🚀
Closes #11929
Deprecates experimental testing utilities introduced in 3.10 in favor of
graphql-testing-library
.