Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue accessing mutations from devtools #11946

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

jerelmiller
Copy link
Member

#11936 introduced a new way to configure devtools so that we can add support for additional options in the future to enable new capabilities. Unfortunately I forgot to replace a reference to connectToDevtools in the constructor for the onBroadcast option which is needed to create the mutationStore accessed by devtools. As such, mutations were not showing up in devtools.

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: b92c06f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jerelmiller
Copy link
Member Author

/release:pr

Copy link
Contributor

Please add a changeset via npx changeset before attempting a snapshot release.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.24 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.99 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.51 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.34 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.2 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.24 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.31 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.79 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.16 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.65 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.34 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)

@jerelmiller
Copy link
Member Author

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11946-20240710142240

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 9d74e32
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9895858a560008626848
😎 Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller force-pushed the jerel/fix-mutation-access branch from 4c1ce93 to b858198 Compare July 10, 2024 14:27
@jerelmiller jerelmiller marked this pull request as ready for review July 10, 2024 14:27
Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions github-actions bot added the auto-cleanup 🤖 label Jul 10, 2024
@jerelmiller
Copy link
Member Author

Oops, I suppose I do need that changeset after all so that we can trigger a new rc. I'll add it back 😆

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 4c1ce93
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e98fb9a1e9600071551e1
😎 Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit b858198
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9a4906d0a300087b3281
😎 Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit b92c06f
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/668e9bf9e96d3000089226ab
😎 Deploy Preview https://deploy-preview-11946--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller merged commit 7d833b8 into release-3.11 Jul 10, 2024
36 checks passed
@jerelmiller jerelmiller deleted the jerel/fix-mutation-access branch July 10, 2024 14:43
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants