Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetchMore for queries with no-cache fetch policies #11974

Merged
merged 40 commits into from
Aug 1, 2024
Merged

Fix fetchMore for queries with no-cache fetch policies #11974

merged 40 commits into from
Aug 1, 2024
+462 −46

Commits on Jul 31, 2024

  1. Export data from paginated scenerio

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7c9b7f0 View commit details
    Browse the repository at this point in the history

  2. Add failing test for fetchMore with no-cache

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0e58815 View commit details
    Browse the repository at this point in the history

  3. Add failing test for fetchMore using cache with no-cache query

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    dc838ee View commit details
    Browse the repository at this point in the history

  4. Add test for updateQuery with no-cache query

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1c3953e View commit details
    Browse the repository at this point in the history

  5. Don't write to cache if fetch policy is no-cache on fetchMore

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b45914f View commit details
    Browse the repository at this point in the history

  6. Add rough implementation for no-cache with updateQuery function

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1a85c92 View commit details
    Browse the repository at this point in the history

  7. Throw if updateQuery is not provided for no-cache query

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    069a067 View commit details
    Browse the repository at this point in the history

  8. Add updateQuery to tests

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9e61193 View commit details
    Browse the repository at this point in the history

  9. Tweak error message

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9666ecd View commit details
    Browse the repository at this point in the history

  10. Add changesets

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9bf4b09 View commit details
    Browse the repository at this point in the history

  11. Update size limits

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    aa649d4 View commit details
    Browse the repository at this point in the history

  12. Tweak changeset

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    18bab57 View commit details
    Browse the repository at this point in the history

  13. Add check for getCurrentResult in test to ensure last result is stored

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a5f818b View commit details
    Browse the repository at this point in the history

  14. Use a variable to track the fetch policy

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8e974c9 View commit details
    Browse the repository at this point in the history

  15. Only update data on the result

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    46e720e View commit details
    Browse the repository at this point in the history

  16. Inline the result passed to reportResult

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f9caa96 View commit details
    Browse the repository at this point in the history

  17. Swap conditional order

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2ada7bc View commit details
    Browse the repository at this point in the history

  18. Simplify test checking for multiple fetches

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c9259cc View commit details
    Browse the repository at this point in the history

  19. Use link from helper in test

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3b51fcd View commit details
    Browse the repository at this point in the history

  20. Track loading and networkStatus in test with fetchMore

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1aa8e59 View commit details
    Browse the repository at this point in the history

  21. Don't track data in test that checks error

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c3619b2 View commit details
    Browse the repository at this point in the history

  22. Don't check intermediate status in error test

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a1a60c8 View commit details
    Browse the repository at this point in the history

  23. Remove intermediate checks on test that checks fetches

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c07a358 View commit details
    Browse the repository at this point in the history

  24. Wrap call to fetchMore in act

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2a96de8 View commit details
    Browse the repository at this point in the history

  25. Add comment explaining lastResult

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    01ea4cc View commit details
    Browse the repository at this point in the history

  26. Tweak grammar in changesets 

    Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
    @jerelmiller @phryneas
    jerelmiller and phryneas committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b254203 View commit details
    Browse the repository at this point in the history

  27. Simplify the result in fetchMore call

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fb02056 View commit details
    Browse the repository at this point in the history

  28. Add section about using fetchMore with no-cache queries

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    030b281 View commit details
    Browse the repository at this point in the history

  29. Add section for updateQuery

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4dd100b View commit details
    Browse the repository at this point in the history

  30. Add tip about defining field policy

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e4d39f6 View commit details
    Browse the repository at this point in the history

  31. Remove 'will'

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9672be1 View commit details
    Browse the repository at this point in the history

  32. More updates to verbiage

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e682f5a View commit details
    Browse the repository at this point in the history

  33. Fix incorrect term used

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    50a54a3 View commit details
    Browse the repository at this point in the history

  34. Add additional clarification

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fb3b8b9 View commit details
    Browse the repository at this point in the history

  35. Fix another incorrect term

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ab7e1d0 View commit details
    Browse the repository at this point in the history

  36. Simplify sentence

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8d0aba8 View commit details
    Browse the repository at this point in the history

  37. Minor tweak to language

    @jerelmiller
    jerelmiller committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c210a03 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Use keyArgs: false in second example to continue previous example

    @jerelmiller
    jerelmiller committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    319622a View commit details
    Browse the repository at this point in the history

  2. Add additional clarifying sentence

    @jerelmiller
    jerelmiller committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ee3165b View commit details
    Browse the repository at this point in the history

  3. Clean up Prettier, Size-limit, and Api-Extractor

    @jerelmiller @github-actions
    jerelmiller authored and github-actions[bot] committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    aca0f10 View commit details
    Browse the repository at this point in the history