-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not forceUpdate if consuming component is not mounted #7745
Conversation
There are two failing tests. I have to invest some time, to find out, how they should be changed, or to check if their failing is correct. Can you help? Check out test details. |
It would be great if someone with deeper knowledge of the project could check this 🙏 |
I’m taking a look. The test suite is finicky. Thanks for the help! |
@brainkim |
This fixes the warning "Can't perform a React state update on an unmounted component".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebasing against release-3.4 seems to have fixed the breaking tests. I was doing work related to React.StrictMode which may have made the tests more robust maybe 🙈. It’s unfortunate that this might mean we might not get to backport it to 3.3 but 3.4 is looking to be a pretty nice release with a lot of fixes and stuff. Thanks for looking into this @wuarmin.
@brainkim thank you. I'm looking forward to 3.4. |
Thank you! I was experiencing this warning when a query unmounted at the same time as |
This change would fix the occurrence of the warning "Can't perform a React state update on an unmounted component" using
useQuery
in React.StrictMode.#6209
best regards