Resolve ts-invariant/process module identifier again in config/resolveModuleIds.ts
#9083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
appease-webpack-5-fullySpecified-errors
branch
from
c767c02
to
5dacee3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
@apollo/client@3.5.0until my recent PR #9073 (v3.5.3), non-relative imported module identifiers likets-invariant/processwere rewritten during the build process (duringnpm run resolve) to include a specific module with a file extension (not a directory), producing in this examplets-invariant/process/index.js.That rewriting was the wrong choice in general (for example, it would rewrite
graphqltographql/index.mjs), so PR #9073 disabled the rewriting for all non-relative imports.However, the specific replacement of
ts-invariant/processwithts-invariant/process/index.jsis still useful to prevent the strange webpack 5-specific errorwhich apparently happens because the
resolve.fullySpecifiedoption istrueby default now. App developers could configureresolve.fullySpecifiedexplicitlyfalse, but we (the Apollo Client team) prefer a general workaround.In other words, this PR refines the changes from #9073 to reenable one specific non-relative module rewriting (the same module mentioned in the commit message 60e18e9,
ts-invariant/process).