This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Use fetch-ponyfill instead of isomorphic-fetch polyfill #22
Comments
ctavan
added a commit
to ctavan/apollo-fetch
that referenced
this issue
Aug 7, 2017
Use a fetch ponyfill instead of modifying the global scope and polyfilling the fetch API. Closes apollographql#22.
ctavan
added a commit
to ctavan/apollo-fetch
that referenced
this issue
Aug 7, 2017
Use a fetch ponyfill instead of modifying the global scope and polyfilling the fetch API. Closes apollographql#22.
8 tasks
ctavan
added a commit
to ctavan/apollo-fetch
that referenced
this issue
Aug 7, 2017
Use a fetch ponyfill instead of modifying the global scope and polyfilling the fetch API. Closes apollographql#22.
ctavan
added a commit
to ctavan/apollo-fetch
that referenced
this issue
Aug 11, 2017
Use a fetch ponyfill instead of modifying the global scope and polyfilling the fetch API. Closes apollographql#22.
ctavan
added a commit
to ctavan/apollo-fetch
that referenced
this issue
Aug 14, 2017
Use a fetch ponyfill instead of modifying the global scope and polyfilling the fetch API. Closes apollographql#22.
Link issues i facing on react-native :( |
This really needs to be resolved. @ctavan is your PR ready? |
@joarwilk as outlined in #30 I believe With that change it would be very simply to provide your own fetch-ponyfill when using the regular |
#71 uses |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Following my reasoning in apollographql/apollo-client#2008 I think it would be a good practice if a library like
apollo-fetch
did not modify the global namespace by polyfillingfetch
.Is there any particular reason not to use https://github.com/qubyte/fetch-ponyfill instead? If you would accept a ponyfill instead of a polyfill I'd be happy to contribute a PR.
Bundle-size wise there should be no signifcant difference.
The text was updated successfully, but these errors were encountered: