fix: Local cache mutation build error in Swift 6 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
calvincestari
force-pushed
the
fix/swift-6-modify-setter
branch
from
df20428
to
1007b06
Compare
calvincestari
force-pushed
the
fix/swift-6-modify-setter
branch
from
afc0b27
to
2a23da4
Compare
BobaFetters
approved these changes
Jul 5, 2024
|
Thanks @BobaFetters. Let's get @AnthonyMDev's opinion too before merging. |
|
If this compiles and builds now, I'm good with merging it! When I initially did this work, I don't believe it was possible to include a |
This reverts commit 2a23da4.
calvincestari
force-pushed
the
fix/swift-6-modify-setter
branch
from
7a6bb90
to
4af6ea3
Compare
calvincestari
force-pushed
the
fix/swift-6-modify-setter
branch
from
2ba1391
to
ed6b71c
Compare
Yes, this builds with both Xcode 15.4 and Xcode 16 without the setter. |
BobaFetters
pushed a commit
that referenced
this pull request
Jul 11, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jul 11, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jul 11, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 11, 2024
9b87ee08 fix: Local cache mutation build error in Swift 6 (#417) git-subtree-dir: apollo-ios git-subtree-split: 9b87ee082dfefa4036ce189fdeb5e52b3f952bef
BobaFetters
pushed a commit
that referenced
this pull request
Jul 11, 2024
…n Swift 6 git-subtree-dir: apollo-ios git-subtree-mainline: 3497c4a git-subtree-split: 9b87ee082dfefa4036ce189fdeb5e52b3f952bef
BobaFetters
pushed a commit
that referenced
this pull request
Jul 11, 2024
fb192097 fix: Local cache mutation build error in Swift 6 (#417) git-subtree-dir: apollo-ios-codegen git-subtree-split: fb1920971dea2158458bd2b1896653edbf934594
BobaFetters
pushed a commit
that referenced
this pull request
Jul 11, 2024
… error in Swift 6 git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 571b2ca git-subtree-split: fb1920971dea2158458bd2b1896653edbf934594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-ios#3398. Gets Xcode 16 successfully building local cache mutations.
@availableattribute. There is no functional change to the code because the setter was unable to be called anyways. So the only real loss is the convenience message displayed to the user if they did try to mutate the entire fragment instead of properties on the fragment. We could state this explicitly in the local cache mutation documentation if we think that would be helpful instead.I also removed the "CI Tests (Xcode 16.0 Beta)" action that I added for us to manually run our CI suite on Xcode 16.0 beta. This was not as useful as I initially thought because it's catching all the concurrency (This is back but with a reduced test suite that ensures the project can build and run unit tests (not codegen test configuration tests though) with Xcode 16.Sendable) related issues too which we know are a much more complex problem to resolve.I suggest we continue to monitor the Xcode 16 beta releases and if this turns out to be a beta glitch then we can revert this PR to get back the setter with attribute and users will get the nice warning message again if they try mutate the entire fragment.