Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor config files #419

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add editor config files #419

merged 2 commits into from
Jul 10, 2024

Conversation

BobaFetters
Copy link
Member

Adding editor config files for apollo dev and ios/codegen/pagination packages

Closes apollographql/apollo-ios#3404

Adding editor config files for apollo dev and ios,codegen,pagination packages
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 7c1ed54
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/668d6eb090a305000889945b

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 7c1ed54
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/668d6eb04f38c300086979df

@BobaFetters
Copy link
Member Author

@AnthonyMDev @calvincestari Thoughts on having a single .editorconfig at the apollo-ios-dev level for everything vs also having one for each package (ios, codegen, pagination) since currently we do all development through dev?

@calvincestari
Copy link
Member

@AnthonyMDev @calvincestari Thoughts on having a single .editorconfig at the apollo-ios-dev level for everything vs also having one for each package (ios, codegen, pagination) since currently we do all development through dev?

I think one at the Tuist project level should be sufficient; that's where we want everyone to develop from and all sub-projects should have the same formatting.

@BobaFetters BobaFetters merged commit e50e407 into main Jul 10, 2024
22 checks passed
@BobaFetters BobaFetters deleted the editor-config branch July 10, 2024 04:54
BobaFetters added a commit that referenced this pull request Jul 10, 2024
AnthonyMDev pushed a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.editorconfig
2 participants