Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick ObjectData type check to ListData #473

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Aug 30, 2024

Cherry-picking the same type data check from ObjectData into ListData. See #459.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit a4f6284
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/66e1fb534e7d2e0008226138

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit a4f6284
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/66e1fb5390b63600089a7e43

@calvincestari calvincestari marked this pull request as ready for review September 10, 2024 22:57
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM

@calvincestari calvincestari merged commit 719cf6d into main Sep 13, 2024
37 checks passed
@calvincestari calvincestari deleted the fix/objectdata-list-type-check branch September 13, 2024 16:16
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Sep 13, 2024
BobaFetters pushed a commit that referenced this pull request Sep 13, 2024
6c967447 fix: Cherry pick `ObjectData` type check to `ListData` (#473)

git-subtree-dir: apollo-ios
git-subtree-split: 6c96744741d811f3d3114d0507c0ec3e3769a4a2
BobaFetters pushed a commit that referenced this pull request Sep 13, 2024
…k to `ListData`

git-subtree-dir: apollo-ios
git-subtree-mainline: 8522355
git-subtree-split: 6c96744741d811f3d3114d0507c0ec3e3769a4a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants