ci: Fix GH action to accurately show test result #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
force-pushed
the
ci/fix-test-result-failure-notification
branch
from
141cbc8
to
187d58e
Compare
AnthonyMDev
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert and improvement of #458.
continue-on-errorinaccurately reflects the test outcome as succeeded. Here is the workflow summary for chore: Required swift-tools-version update #479 which is correctly failing a codegen test but incorrectly showing the entire CI run as successful. At the time of doing ci: Continue on error if unit test fails #458 I'd assumed it would still fail the step but allow other downstream jobs to still go ahead, turns out that's not how it works. 😬failure()as theifcondition for the downstream logging jobs.