Batch writing of records to SQLite store #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
force-pushed
the
sqlite-batch-write
branch
from
ef590dd
to
c71a8bc
Compare
calvincestari
approved these changes
Oct 1, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 1, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Oct 1, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 1, 2024
8e4cbf79 Batch writing of records to SQLite store (#498) git-subtree-dir: apollo-ios git-subtree-split: 8e4cbf79b73d1c507a8755bc4dc177576c87b534
BobaFetters
pushed a commit
that referenced
this pull request
Oct 1, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 6ca3c07 git-subtree-split: 8e4cbf79b73d1c507a8755bc4dc177576c87b534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
insertManyto batch the writing of records to the SQLite cache. Previously we were running separate DB transaction/query for each individual record written. This should significantly improve performance of File I/O for cache writes.We are investigating utilizing the Benchmarks package at some point in the future to measure the performance improvement, but that project is blocked for now and we should still release this performance improvement in the mean time.