ApolloSQLite -> Fix deserialize method for custom scalars

[ppowers10]

Fix:

See Spectrum conversation regarding this issue

Changes:

• Removed invalidRecordValue as it is no longer used anywhere

• Updated deserialize method to return fieldJSONValue when a lack of a $reference value is found. This allows custom scalar types to return properly rather than throwing the error.

• Updated tests to remove any invalidRecordValue thrown errors from SQLiteNormalizedCacheError as they are not used anymore. Instead, this test fails in the same manner that InMemoryNormalizedCache due to a JSONDecodingError.

• Tests Passing

[apollo-cla]

@ppowers10: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[designatednerd]

I think you can just do this and have this be a lot simpler:

switch graphQLError.underlying {
case JSONDecodingError.couldNotConvert(value: _, to: _)?:
  break
default: 
   XCTFail("Invalid error type")
}

[ppowers10]

@designatednerd - The above change was made, but it looks like CircleCI is complaining about ci/circleci: Apollo iOS 12.4 build. I ran the tests locally and didn't see any issues. I'm unable to trigger the build process again to see if it might pass and it was a glitch. My previous code passed all the tests on all the CircleCI checks.

[designatednerd]

Yeah there's one test that gets flaky a decent amount - I'll kick the build

[designatednerd]

(approved, obviously)

[gsabran]

👍

[gsabran]

👍