Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apollo custom extension to replace apollo_ prefix #1183

Merged
merged 4 commits into from
May 7, 2020
Merged

Add apollo custom extension to replace apollo_ prefix #1183

merged 4 commits into from
May 7, 2020

Conversation

yuzushioh
Copy link
Contributor

@yuzushioh yuzushioh commented May 3, 2020 •
edited
Loading

Added ApolloExtension and replace apollo_ prefix by apollo. ref: #1170

@apollo-cla
Copy link

@yuzushioh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@yuzushioh yuzushioh changed the title [WIP] Add apollo custom extension to replace apollo_ prefix Add apollo custom extension to replace apollo_ prefix May 3, 2020
@yuzushioh
Copy link
Contributor Author

@designatednerd testWatchedQueryGetsUpdatedWithListReorderingFromOtherQuery is failing for some reason. I am not sure if it's because of my change

@designatednerd
Copy link
Contributor

@yuzushioh Prooooobably not, that test is super flaky, I'll kick it

designatednerd
designatednerd reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing but otherwise this is looking nice!

Note that since this is technically going to be a break I'll need to put it in a minor version, so I may hold off on merging it for a few days until I have something else breaking.

Sources/ApolloCodegenLib/OptionalBoolean.swift Outdated
@@ -1,8 +1,7 @@
import Foundation

extension Optional where Wrapped == Bool {

var apollo_boolValue: Bool {
var valueOrFalseIfNone: Bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to keep this as boolValue - ultimately it behaves similarly to [NSNumber boolValue] in that if you call it on nil it returns false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I changed it to boolValue with a comment on it.

@yuzushioh yuzushioh marked this pull request as ready for review May 4, 2020 03:20
designatednerd
designatednerd approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm going to hold off on merging this for a few days to make sure I don't need to do more patches for 0.27.x, but I'll put it out with our next minor!

@yuzushioh yuzushioh mentioned this pull request May 5, 2020
Closed
@designatednerd designatednerd added this to the Next Release milestone May 7, 2020
@designatednerd designatednerd merged commit 015e534 into apollographql:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzushioh @apollo-cla @designatednerd