Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebSockTransport request header and connectingPayload #1224

Merged

Conversation

yootsubo
Copy link
Contributor

Addresses #1178

In addition, added a similar functionality to update the connectingPayload.
This is to handle similar use case to #1178 but for those who use the connectingPayload to send the auth token (what my team is currently doing).

@apollo-cla
Copy link

@yootsubo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@designatednerd
Copy link
Contributor

Awesome - any chance you've got a minute to throw some tests on for this?

@gazzer82
Copy link

Thanks for doing this, got swamped the last few days!

@yootsubo
Copy link
Contributor Author

@designatednerd Tests added! Let me know if theres anything else :)

Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! I might do some stuff tomorrow to have it hit a live websocket on localhost instead of using a mock socket, but this is fantastic. Thanks so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants