Adopt `.apollo.method()` namespacing for extensions #1256

designatednerd · 2020-06-12T02:44:52Z

This PR:

moves us to more consistent usage of the apollo.blah() way of sending extension methods through a namespace. This requires some silliness with Protocols With Associated Types for a couple things involving generics, but I think the consistency is worth it.
Adds some more readable extension methods on URLs. I plan to update the Swift Codegen setup with this once it's merged, since it makes things a LOT clearer.
Moves a couple things, including Atomic, to ApolloCore. This is mostly going to serve as a check that migrating more things to core isn't going to break everything for now, but I plan to move more stuff not necessary outside of reading in code-generated files into Core to help deal with Generated types import the entire Apollo runtime #1047

…lo dot syntax

…apper.

…paths.

… too generic

designatednerd added 17 commits June 10, 2020 12:25

move extension mechanism and isEmpty helpers into core

1b61236

add some more readable URL extensions

3928778

use apollo extensions in codegen for clarity

23d0d83

move optional boolean to core lib and get it working better with apol…

f6b2bc1

…lo dot syntax

Add PAT for dictionary and convert toStringKeyedDict to use apollo wr…

71f5df8

…apper.

fix failing test and use a more reliable method of getting different …

8d033ab

…paths.

move atomic to core and put extensions into a folder

9deb15a

fix a couple breaks in the main lib

b51e38e

update bundle extension to use apollo namespace

37e0646

Update http response extension to use apollo namespace

7655781

update dispatch queue to use apollo namespace

9656b19

move the SHA256 hash extension to core

fcb7b89

Update result extension to use apollo namespace

79dafa9

Change naming to use underlying instead of value since value is…

21b3314

… too generic

add tries to argument setup

f72309c

fix cache dependent tests

c8e7da9

fix main apollo tests

83cedf5

designatednerd merged commit b66f99d into master Jun 12, 2020

designatednerd deleted the update/namespacing branch June 12, 2020 13:46

designatednerd added this to the Next Release milestone Jun 30, 2020

Provide feedback