Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12 + iOS 14 + Swift 5.3 + associated Updates #1280

Merged
merged 19 commits into from
Sep 15, 2020
Merged

Conversation

designatednerd
Copy link
Contributor

This branch is where updates for Xcode 12, Swift 5.3, iOS/tvOS 14, watchOS 7, and macOS 11 will live until it comes out of beta. Thus far it includes [will try to keep this up to date]:

  • Pointed Circle at Xcode 12 image
  • Added a demo playground for queries, mutations, and subscriptions

If you've got a bugfix or a feature specific to Xcode 12 or the associated Swift/OS versions, please open a PR against this branch rather than against main. This branch will not be merged to main until the final version of Xcode 12 is released.

@designatednerd designatednerd added the beta-xcode Issues occurring on a beta version of Xcode label Jun 29, 2020
@designatednerd designatednerd force-pushed the betas/xcode-12 branch 2 times, most recently from d1066da to f015b4f Compare June 30, 2020 23:02
@danl3v
Copy link

danl3v commented Jul 1, 2020

Thanks for this. When using Carthage + Xcode 12 Beta 1 to build Apollo, I ran into a few issues. I think there is something wrong in the beta with the Substring implementation, and I am hopeful that these issues will be fixed naturally in an upcoming Xcode beta.

  1. SQLite would not build - stephencelis/SQLite.swift@master...danl3v:xcode-12
  2. Apollo had a few issues - main...danl3v:xcode-12

@designatednerd
Copy link
Contributor Author

Hey @danl3v - Thanks for the heads up. On Apollo, how did you determine those issues? I am not seeing warnings at any of the places you've changed the code.

@danl3v
Copy link

danl3v commented Jul 2, 2020

We are a version or two back. If you pull down 0.27.1, open Xcode 12, and archive, I was getting these failures. I'll test on newer versions. Good excuse to update :)

@danl3v
Copy link

danl3v commented Jul 22, 2020

I checked on 0.29.1 and am still not able to build with Carthage. Fixes here for 0.29.1: https://github.com/danl3v/apollo-ios/tree/0.29.1-xcode12

@designatednerd
Copy link
Contributor Author

@danl3v Can you please try with Xcode 12 beta 3? Thank you!

@danl3v
Copy link

danl3v commented Jul 22, 2020

Sure can do. Will be next week since I am out the rest of the week. Will report back here

@designatednerd designatednerd force-pushed the betas/xcode-12 branch 2 times, most recently from 07b65f7 to 851856d Compare July 29, 2020 00:26
@designatednerd designatednerd force-pushed the betas/xcode-12 branch 2 times, most recently from ca4b06a to 62fda0f Compare August 4, 2020 21:28
@GyroJoe
Copy link

GyroJoe commented Aug 6, 2020

Hey @designatednerd - I'm not that familiar with SwiftPM, but it seems to have trouble handling updates to this branch made via force push (and sadly, Xcode's error message here is not very helpful):

/Applications/Xcode-beta.app/Contents/Developer/usr/bin/git -C <snipped>/SourcePackages/repositories/apollo-ios-93144027 rev-parse --verify '851856d9d9191e63c7b7d3417531821ad7c4bc26^{commit}' output:
    fatal: Needed a single revision

Possible there's a better way to approach this - for now we just manually update Package.resolved on branch updates.

@designatednerd
Copy link
Contributor Author

I suppose that makes sense because when rebasing it updates all the commit hashes, and the hash that was pinned by the Package.resolved goes 💥.

I think long term I still want to keep rebasing rather than merging because it'll make the changeset way less insane when I do merge all this, but I appreciate you posting here so people see this and know how to resolve the issue!

@danl3v
Copy link

danl3v commented Aug 6, 2020

To follow up when archiving apollo with Xcode 12 betas, beta 4 fixes the issue for me. Thanks for the support!

@designatednerd
Copy link
Contributor Author

@danl3v Good to hear confirmation! #1300 also reported this.

@designatednerd designatednerd force-pushed the betas/xcode-12 branch 2 times, most recently from 9790166 to 2642e18 Compare September 11, 2020 01:35
@designatednerd designatednerd marked this pull request as ready for review September 15, 2020 19:44
@designatednerd designatednerd changed the title [DRAFT] Xcode 12 + associated Updates Xcode 12 + associated Updates Sep 15, 2020
@designatednerd designatednerd changed the title Xcode 12 + associated Updates Xcode 12 + iOS 14 + Swift 5.3 + associated Updates Sep 15, 2020
@designatednerd
Copy link
Contributor Author

Good news: This branch is working fine on Intel hardware if you need to integrate it immediately
Bad news: I'm still fighting with the Apple Silicon hardware

@designatednerd
Copy link
Contributor Author

I'm going to open a new issue on the Apple Silicon problems and merge this - at this point nobody has silicon macs yet and people need to be able to release tomorrow.

@designatednerd designatednerd merged commit a6b4871 into main Sep 15, 2020
@designatednerd designatednerd added this to the Next Release milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-xcode Issues occurring on a beta version of Xcode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants