Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent request headers from getting lost #1420

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Prevent request headers from getting lost #1420

merged 2 commits into from
Sep 29, 2020

Conversation

dchohfi
Copy link
Contributor

@dchohfi dchohfi commented Sep 29, 2020

I believe that this fixes #1419

@apollo-cla
Copy link

@dchohfi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

designatednerd
designatednerd approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, whoops. 🙃

Thanks for adding tests!

@designatednerd
Copy link
Contributor

Test failure is a known flaky test, rerunning then I'll get this merged

@designatednerd designatednerd added the bug Generally incorrect behavior label Sep 29, 2020
@designatednerd designatednerd added this to the Next Release milestone Sep 29, 2020
@designatednerd designatednerd merged commit 0f2eb0f into apollographql:main Sep 29, 2020
@dchohfi
Copy link
Contributor Author

dchohfi commented Sep 30, 2020

Hey, thank you for merging this, can we get a new tag out? This is breaking my migration.

@designatednerd
Copy link
Contributor

Yeah will try to get this out today - you can also point at the commit on main if you need it right away.

@dchohfi dchohfi deleted the dchohfi/prevent-headers-lost branch November 3, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielrinaldi gabrielrinaldi gabrielrinaldi approved these changes

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
bug Generally incorrect behavior
Projects
None yet
Milestone
0.34.1
Development

Successfully merging this pull request may close these issues.

JSONRequest losing headers when useGETForQueries is true
4 participants
@dchohfi @apollo-cla @designatednerd @gabrielrinaldi