Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cache policy case .default in fetch and watch #1737

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Apply cache policy case .default in fetch and watch #1737

merged 1 commit into from
Apr 1, 2021

Conversation

deepumukundan
Copy link
Contributor

The CachePolicy enum has a default policy but it was only used in subscribe. This updates the other 2 locations

The CachePolicy enum has a default policy but it was only used in subscribe. This updates the other 2 locations
@apollo-cla
Copy link

@deepumukundan: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@deepumukundan
Copy link
Contributor Author

@designatednerd Could you merge this? I don't have merge rights

@designatednerd
Copy link
Contributor

Thanks for the poke! I had to rerun one test then promptly forgot about it 🤦‍♀️

@designatednerd designatednerd merged commit e2be065 into apollographql:main Apr 1, 2021
@designatednerd designatednerd added this to the Next Release milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants