Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump apollo-server from 2.16.1 to 2.25.3 in /SimpleUploadServer #2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 8, 2021

Bumps apollo-server from 2.16.1 to 2.25.3.

Changelog

Sourced from apollo-server's changelog.

v2.25.3

  • ⚠️ SECURITY apollo-server-core: Update default version of the GraphQL Playground React app loaded from the CDN to be @apollographql/graphql-playground-react@1.7.42. This patches an XSS vulnerability. Note that if you are pinning the Playground React app version in your app with new ApolloServer({playground: {version: 'some version'}}), you will need to update the specified version to 1.7.42 or later to avoid this vulnerability. If you disable GraphQL Playground with new ApolloServer({playground: false}), this vulnerability does not affect you. See advisory GHSA-qm7x-rc44-rrqw for more details.

v2.25.2

v2.25.1

  • apollo-server-core, apollo-server-express: Upgrade subscriptions-transport-ws dependency and remove unneeded runtime dependency on ws. This should enable you to install Apollo Server without depending on versions of ws vulnerable to CVE-2021-32640. Note that the superficial integration of the unmaintained subscriptions-transport-ws package will be removed in Apollo Server 3; you can also avoid this vulnerability by disabling the built-in subscription support with new ApolloServer({subscriptions: false}) and using a maintained package such as graphql-ws instead. (Instead of taking this upgrade, you can also upgrade ws to 5.2.3, which was just released.)

v2.25.0

  • apollo-server-core: You may now specify your Studio graph as a graph ref (id@variant) via the APOLLO_GRAPH_REF environment variable or new ApolloServer({apollo: {graphRef}}) instead of specifying graph ID and graph variant separately. The apollo object passed to plugin serverWillStart and to gateway load now contains a graphRef field.
  • apollo-server-core: Fix a race condition where schema reporting could lead to a delay at process shutdown. [PR #5222](apollographql/apollo-server#5222)
  • apollo-server-core: Allow the Fetch API implementation to be overridden for the schema reporting and usage reporting plugins via a new fetcher option. [PR #5179](apollographql/apollo-server#5179)
  • apollo-server-core: The server.executeOperation method (designed for testing) can now take its query as a DocumentNode (eg, a gql-tagged string) in addition to as a string. (This matches the behavior of the apollo-server-testing createTestClient function which is now deprecated.) We now recommend this method instead of apollo-server-testing in our docs. [Issue #4952](apollographql/apollo-server#4952)
  • apollo-server-testing: Replace README with a deprecation notice explaining how to use server.executeOperation instead. [Issue #4952](apollographql/apollo-server#4952)

v2.24.1

  • apollo-server-core: Fix a typo that could lead to TypeScript compilation when combined with a recent version of @types/node. (This bug had no runtime effect.) [PR #5149](apollographql/apollo-server#5149)

v2.24.0

  • apollo-server-core: Apollo Studio usage reporting uses a more efficient format which sends fewer detailed traces to Apollo's server. This change should not have a major effect on the experience of using Apollo Studio. This also fixes a bug in all prior versions where all operations were reported to Studio as "uncached". [PR #4142](apollographql/apollo-server#4142)

v2.23.0

  • apollo-server-core: Add optional argument to ApolloServer.executeOperation allowing the caller to manually specify an argument to the config function analogous to that provided by integration packages. [PR #4166](apollographql/apollo-server#4166) [Issue #2886](apollographql/apollo-server#2886)
  • apollo-server-cache-redis@1.4.0: New BaseRedisCache class which takes an ioredis-compatible Redis client as an argument. The existing classes RedisCache and RedisClusterCache (which pass their arguments to ioredis constructors) are now implemented in terms of this class. This allows you to use any of the ioredis constructor forms rather than just the ones recognized by our classes. This also fixes a long-standing bug where the Redis cache implementations returned a number from delete(); it now returns a number, matching what the KeyValueCache interface and the TypeScript types expect. [PR #5034](apollographql/apollo-server#5034) [PR #5088](apollographql/apollo-server#5088) [Issue #4870](apollographql/apollo-server#4870) [Issue #5006](apollographql/apollo-server#5006)
  • apollo-server-core: Fix type for formatResponse function. It never is called with a null argument, and is allowed to return null. [Issue #5009](apollographql/apollo-server#5009) [PR #5089](apollographql/apollo-server#5089)
  • apollo-server-lambda: Fix regression in v2.21.2 where thrown errors were replaced by throwing the JS Error class itself. [PR #5085](apollographql/apollo-server#5085)
  • apollo-server-core: If a client sends a variable of the wrong type, this is now reported as an error with an extensions.code of BAD_USER_INPUT rather than INTERNAL_SERVER_ERROR. [PR #5091](apollographql/apollo-server#5091) [Issue #3498](apollographql/apollo-server#3498)
  • apollo-server-lambda: Explicitly support API Gateway payloadFormatVersion 2.0. Previously some codepaths did appropriate checks to partially support 2.0 and other codepaths could lead to errors like event.path.endsWith is not a function (especially since v2.21.1). Note that this changes the TypeScript typing of the onHealthCheck callback passed to createHandler to indicate that it can receive either type of event. If you are using TypeScript and care about having a precise typing for the argument to your onHealthCheck callback, you should determine which payload format you want to support and write new ApolloServer<APIGatewayProxyEvent>(...) or new ApolloServer<APIGatewayProxyEventV2>(...) (importing these types from aws-lambda), or differentiate between the two formats by checking to see if 'path' in event. [Issue #5084](apollographql/apollo-server#5084) [Issue #5016](apollographql/apollo-server#5016)

v2.22.2

v2.22.1

  • apollo-server-core: Fix a regression in v2.22.0 where startup errors could be thrown as part of the GraphQL response instead of redacted in one edge case. [PR #5064](apollographql/apollo-server#5064)

v2.22.0

  • Improve startup error handling by ensuring that your server has loaded its schema and executed its serverWillStart handlers successfully before starting an HTTP server. If you're using the apollo-server package, no code changes are necessary. If you're using an integration such as apollo-server-express that is not a "serverless framework", you can insert await server.start() between server = new ApolloServer() and server.applyMiddleware. (If you don't call server.start() yourself, your server will still work, but the previous behavior of starting a web server that may fail to load its schema still applies.) The serverless framework integrations (Lambda, Azure Functions, and Cloud Functions) do not support this functionality. While the protected method willStart still exists for backwards compatibility, you should replace calls to it with start or the new protected method ensureStarting. [PR #4981](apollographql/apollo-server#4981)

v2.21.2

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependency-management Issues with CocoaPods, Carthage, or SPM integration label Nov 8, 2021
@calvincestari calvincestari merged commit a1e857c into main Nov 9, 2021
@calvincestari calvincestari deleted the dependabot/npm_and_yarn/SimpleUploadServer/apollo-server-2.25.3 branch November 9, 2021 00:24
calvincestari added a commit that referenced this pull request Nov 19, 2021
Squashed commit of the following:

commit 3262cd0
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Nov 18 03:49:51 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.8 (#2038)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit d93568f
Author: Calvin Cestari <calvincestari@users.noreply.github.com>
Date:   Wed Nov 17 12:51:58 2021 -0800

    Release `0.50.0` (#2031)

    * Update version number for release
    * Updated changelog for release
    * Update documentation for release changes
    * Update changelog for #2015

commit 46957a3
Author: Hesham Salman <iron-ham@github.com>
Date:   Wed Nov 17 15:15:54 2021 -0500

    Update SQLite.swift to version 13.0 (#2015)

    * Update Package.swift and podspec
    * Updated XcodeProj
    * Bump SQLite.swift minimum required version to 0.13.1

    Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com>

commit 8d48031
Author: hwillson <hugh@octonary.com>
Date:   Fri Nov 12 16:24:18 2021 -0500

    Gateway clarification based on license change

commit 55c5db8
Author: Calvin Cestari <calvincestari@users.noreply.github.com>
Date:   Fri Nov 12 10:47:33 2021 -0800

    Update apollo-tooling to v2.33.9 (#2028)

    * Update to v2.33.9 of the CLI tooling
    * Update StarWarsAPI output generated by updated tooling
    * Update test with expected output
    * Keep the parameter spacing

commit ece5b5b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Nov 10 22:13:58 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.6 (#2026)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit a8a35ae
Author: Anthony Miller <anthonymdev@gmail.com>
Date:   Tue Nov 9 11:50:36 2021 -0800

    Attempted fix for integration test failing on CI (#2024)

commit a1e857c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Nov 8 16:24:21 2021 -0800

    Bump apollo-server from 2.16.1 to 2.25.3 in /SimpleUploadServer (#2020)

    Bumps [apollo-server](https://github.com/apollographql/apollo-server/tree/HEAD/packages/apollo-server) from 2.16.1 to 2.25.3.
    - [Release notes](https://github.com/apollographql/apollo-server/releases)
    - [Changelog](https://github.com/apollographql/apollo-server/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/apollographql/apollo-server/commits/apollo-server@2.25.3/packages/apollo-server)

    ---
    updated-dependencies:
    - dependency-name: apollo-server
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6bf4362
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Nov 9 00:03:55 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.2 (#2021)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 3bfde02
Author: Mike Pitre <mikepitre1@gmail.com>
Date:   Mon Nov 8 13:58:36 2021 -0500

    GET method for `ApolloSchemaDownloader` (#2010)

    * GET method for ApolloSchemaDownloader
    * Minor improvements to HTTP method enum
    * Remove ApolloSchemaDownload scope from name
    * Add documentation
    * Add HTTP method string constants as output
    * Add error for unsupported HTTP method when using Apollo Registry
    * Move HTTP method support into DownloadMethod
    * Build requests based on DownloadMethod
    * Add tests for DownloadMethod HTTP method configurations
    * Clean up and clarify documentation
    * Add associated values to URL-related errors

    Co-authored-by: Calvin Cestari <calvin.cestari@gmail.com>

commit 9cab672
Author: Calvin Cestari <calvincestari@users.noreply.github.com>
Date:   Wed Nov 3 12:48:57 2021 -0700

    Expose `cacheKey` function as `public` (#2014)

    * Expose cacheKey function as public
    * Remove @testable attribute to require public access to cacheKey function

commit f2a4983
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Oct 28 01:40:10 2021 +0000

    fix(deps): update dependency gatsby-theme-apollo-docs to v5.3.1 (#2006)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
@danabrooks
Copy link

Should this PR have also changed the apollo-server version in the package.json file?

@calvincestari
Copy link
Member

@danabrooks I don't believe so. This was a minor version bump going from 2.16.1 to 2.25.3. Package.json correctly has the version tag set to accept all minor version bumps within the 2.x.x major version release.

Are you possibly meaning why we're not bumping up to 3.x?

@danabrooks
Copy link

@calvincestari - No, nothing to do with 3.x, but in our forked version of apollo-ios that we've been using, the 2.16.1 version was popping up on a scan showing possible vulnerabilities in some of the indirect dependencies. The scanner was finding this version in the package.json file. I changed it in our fork by changing the package.json file, then updating the package-lock.json and committing both files. I was just thinking it might show up on some scans in the future. Thanks!

@calvincestari
Copy link
Member

calvincestari commented Feb 4, 2022

Hmm, the same problem exists with the Node-based documentation generation system. The vulnerability scanners are a bit overzealous in what they check, i.e.: not everything is production shipped code.

We do need to upgrade SimpleUploadServer to apollo-server 3.x though, or strip it out of this repo.

@danabrooks
Copy link

Understood - I'll keep an eye out for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-management Issues with CocoaPods, Carthage, or SPM integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants