fix: Xcode integration for Swift Package Plugins #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
calvincestari
commented
Oct 7, 2022
| @@ -62,9 +62,6 @@ let package = Package( | |||
| exclude: [ | |||
| "Info.plist", | |||
| "Frontend/JavaScript", | |||
| ], | |||
There was a problem hiding this comment.
This was forgotten about in #2548 resulting in a warning in Xcode.
calvincestari
commented
Oct 7, 2022
| name: SwiftPM - Build package | ||
| - run: | ||
| working_directory: Tests/CodegenCLITests/swiftpm-test/ | ||
| command: swift package plugin --allow-writing-to-package-directory apollo-generate --verbose |
There was a problem hiding this comment.
We only test the generate command here because we needed have an existing JSON config file to prevent codegen finding all the test graphQL definition files in the .build folder. We're going to fix that behaviour in #2552.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2543
The Xcode integration for SwiftPM plugins was not working correctly.
This PR fixes than through the following:
XcodePluginContextto correctly route the command--targetcommand line option which was being sent by Xcode