Fix escaping input params #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this is sufficient, but I have some input objects with fields named `in` and this change allows my generated code to compile.
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Looks good, just one question. Thanks for the contribution @puls and the additional tests @AnthonyMDev
Sources/ApolloCodegenLib/Templates/RenderingHelpers/String+SwiftNameEscaping.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@puls Thanks for the initial fix. This just adds tests and escapes the reserved names in the getters and setters as well.