Generate library for test mock target #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docs pending review.Visit the deploys page to approve it
|
|
Thanks for this! We definitely should get this added. I'll do a full review ASAP to make sure this is good to go before merging. And you can ignore that integration test failure. It's a known issue and we're working on it. |
AnthonyMDev
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you generate the test mocks for a Swift package it won't create a library for it, so you can't import the test mocks properly into your unit tests.
To fix this I've updated the SwiftPackageManagerModuleTemplate to also create a library for the test mocks if there is a testMockTarget.