fix: Schema/Target/Module name with spaces breaks generated code #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
commented
Jan 9, 2023
| /// is only a static analysis of the configuration. | ||
| /// | ||
| /// - Parameter config: Code generation configuration settings. | ||
| public static func _validate(config: ApolloCodegenConfiguration) throws { |
There was a problem hiding this comment.
The public method prefixed with _ to indicate that while it's public it is still considered private.
calvincestari
commented
Jan 9, 2023
AnthonyMDev
approved these changes
Jan 9, 2023
| @@ -76,14 +79,14 @@ public class ApolloCodegen { | |||
| rootURL: rootURL | |||
| ) | |||
|
|
|||
| try validate(config: configContext) | |||
| try validate(context: configContext) | |||
There was a problem hiding this comment.
These two methods are validating different things I imagine, but it's unclear what those are (other than one uses the compilation result). Can we rename them to indicate what's going on here?
My assumption is that one is validating the context, the other is validating the compilationResult, and just needs info from the context.
If that's the case, I'd suggest
validate(_ context: ConfigurationContext)
and
validate(_ compilationResult: CompilationResult, with context: ConfigurationContext)
There was a problem hiding this comment.
How about this? - a492d54
- Takes the suggestion of the nameless parameter
- Keeps
compilationResultas a second param but using the labelwithbecause it's still validation of the configuration but dependent on the compilation results rather than validating the compilation results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2653
Related to #2664
This PR refactors the flow of configuration validation logic.
ApolloCodegen._validationthat performs config-only validation, not dependent on the schema nor operations, that can be called from the CLI.