Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typename collisions in generated test mocks #2762

Merged
merged 2 commits into from
Jan 9, 2023
Merged

fix: Typename collisions in generated test mocks #2762

merged 2 commits into from
Jan 9, 2023

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Jan 9, 2023 •
edited
Loading

Fixes #2719

@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 57218cc
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/63bc8ebc3b7a9d000928dff7

AnthonyMDev
AnthonyMDev approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn’t realize this was needed for another issue! Looks good! Glad we could reuse the new logic I added here!

@calvincestari calvincestari merged commit 923d4cc into main Jan 9, 2023
@calvincestari calvincestari deleted the fix/testmock-qualifiedtypes branch January 9, 2023 22:21
@calvincestari calvincestari mentioned this pull request Jan 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming collision with DocumentType in generated mock code
2 participants
@calvincestari @AnthonyMDev