fix: Additional reserved keyword #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
commented
Jan 11, 2023
| @@ -129,57 +129,7 @@ class EnumTemplateTests: XCTestCase { | |||
|
|
|||
| // Escaped keywords | |||
| ("associatedtype", nil, nil), | |||
| ("class", nil, nil), | |||
There was a problem hiding this comment.
This is test cleanup - I'm not sure why we need all the escaped keywords in this test so I left two with different casing that require backticks.
AnthonyMDev
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2765
This PR simply adds
forto the list of reserved keywords to escape in backticks.I looked through the Apollo Tooling list and both
openandforwere missing from 1.0 butopenis not an issue in the generated code.