fix: DataDict subscript crash on iOS <= 14.4
#2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
approved these changes
Jan 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2668
It seems that additional type checking was added in Swift
5.4(correlated with Xcode12.5and iOS14.5) which handled the base type conversions/checks ofAnyHashablefor us. On iOS <=14.4accessingDataDictproperties where theAnyHashablevalue isnilcauses a crash. This change adds checks on the base type to prevent the crash.I don't think there are any automated CI checks we can add to test this because of the CircleCI supported environments:
14.2.0image, which we use only has the iOS15.5and16.1runtimes. We would need to download the simulator before being able to run any tests and that will drastically increase CI times.12.5.1image does have iOS runtimes that would work (13.7 and 14.5) but our code would not compile on the older versions of Xcode and Swift.