fix: Adding type name suffixing for reserved keywords #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `formattedName` value to `GraphlQLNamedType` and overrides in subclasses for specific behavior - Added checks for reserved keyword usage to type name to apply appropriate suffixes to avoid conflicts
✅ Deploy Preview for apollo-ios-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
calvincestari
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
This looks great Zach - thanks!
This might need to go out in a minor release since it could change the naming of existing structs/classes in generated code. So it's a breaking change, not a very serious one, but we can't take advantage of Xcode renaming annotation which is the annoying bit for users.
|
@calvincestari Agreed, definitely a minor breaking change and should go out as part of 1.3. |
AnthonyMDev
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formattedNamevalue toGraphlQLNamedTypeand overrides in subclasses for specific behaviorCloses #3006