fix: Update graphql-js error handling #3132
Conversation
-Updating the handling of graphql-js errors to check if source locations exist to determine how to process and display the error -This fixes the issue of reaching the max error limit of graphql-js
✅ Deploy Preview for apollo-ios-docs canceled.
|
| @@ -305,8 +305,14 @@ public class ApolloCodegen { | |||
| ) | |||
|
|
|||
| guard graphqlErrors.isEmpty else { | |||
| let errorlines = graphqlErrors.flatMap({ $0.logLines }) | |||
| CodegenLogger.log(String(describing: errorlines), logLevel: .error) | |||
| let errorlines = graphqlErrors.flatMap({ | |||
There was a problem hiding this comment.
Thinking here is by making the sourceLocations optional and therefore the logLines optional, we can determine how to display a given error, so errors with sourceLocations get displayed as they always have, but errors without sourceLocations no longer cause a precondition failure and instead just have their name and message displayed to ensure the user always gets usable error information
There was a problem hiding this comment.
This is an awesome solution!
| @@ -305,8 +305,14 @@ public class ApolloCodegen { | |||
| ) | |||
|
|
|||
| guard graphqlErrors.isEmpty else { | |||
| let errorlines = graphqlErrors.flatMap({ $0.logLines }) | |||
| CodegenLogger.log(String(describing: errorlines), logLevel: .error) | |||
| let errorlines = graphqlErrors.flatMap({ | |||
There was a problem hiding this comment.
This is an awesome solution!
| if let logLines = $0.logLines { | ||
| return logLines | ||
| } else { | ||
| return ["[Error] \($0.name ?? "unknown"): \($0.message ?? "")"] |
There was a problem hiding this comment.
I believe the [Error] label is already prepended to the log by the CodegenLogger. So putting it here might make it display it twice in the actual log.
There was a problem hiding this comment.
Good callout I'll remove that
-Updating the handling of graphql-js errors to check if source locations exist to determine how to process and display the error
-This fixes the issue of reaching the max error limit of graphql-js
Closes #3126