Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codegen fail for MacPorts users #591

Merged

Conversation

manicmaniac
Copy link
Contributor

Problem

I installed node and npm from MacPorts and don't use Homebrew.
When I build my project, it says node is not found.

... /Pods/Apollo/scripts/check-and-run-apollo-cli.sh: line 45: node: command not found
error: Apollo CLI requires Node 8 or higher to be installed.

But actually node and npm are installed under /opt/local/bin, that is default MacPorts' executable path.

Cause

Xcode doesn't consider MacPorts default path /opt/local/bin and doesn't respect .bashrc.

Solution

Added default MacPorts bin path to codegen script.

@apollo-cla
Copy link

@manicmaniac: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@designatednerd
Copy link
Contributor

Awesome! I'll merge this once CI does its thing

@designatednerd
Copy link
Contributor

OK Travis passed, looks like the webhook just didn't call back. Merging!

@designatednerd designatednerd merged commit f5955e5 into apollographql:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants