Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where a field that was removed from a Record would still exist after a merge. #67

Closed
wants to merge 1 commit into from
Closed

Fixed issue where a field that was removed from a Record would still exist after a merge. #67

wants to merge 1 commit into from

Conversation

mckaskle
Copy link

@mckaskle mckaskle commented Mar 8, 2017

This could happen when a value changed to null. This fixes a bug in the following scenario:

  1. Make a query where field x has value y. The result is cached.
  2. Make the same query but bypass the cache. This time the field x has value null.
  3. Make the same query again but allow fetching from the cache.

Expected Result: field x has value null.
Actual Result: field x still has value y.

The fix was to ensure that keys/fields that do not exist in a new record are removed from the old record during a merge.

…exist after a merge.

This could happen when a value changed to `null`.
@apollo-cla
Copy link

@mckaskle: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@mckaskle
Copy link
Author

mckaskle commented Mar 8, 2017

I'm having trouble resolving the conflicts so I'm going to start over and open a new PR (#68).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants