Include PLATFORM_NAME in bundle identifier
#751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of ~5 days ago, App Store submissions will fail with the ITMS-90806 publishing error code if there are multiple bundles with the same identifier. This is a problem for apps that e.g. include an iOS version alongside a watchOS version. This change just appends the `PLATFORM_NAME` to the bundle identifier to get around the issue. Here's a thread from Apple's message boards about the issue: https://forums.developer.apple.com/thread/122048
|
@nchase: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@nchase There's a thread on CocoaPods' Github about this - Are you using CP to integrate or another method? If it's only CocoaPods having this issue, I'm inclined to recommend this be handled with one of the If you're not using CocoaPods, what are you using? |
designatednerd
added
the
dependency-management
designatednerd
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Buh, looking into Alamofire's handling it appears this is an issue with Carthage too. Thanks so much, 🍎🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ~5 days ago, App Store submissions will fail with the ITMS-90806 publishing error code if there are multiple bundles with the same identifier. This is a problem for apps that e.g. include an iOS version alongside a watchOS version.
This change just appends the
PLATFORM_NAMEto the bundle identifier to get around the issue.Here's a thread from Apple's message boards about the issue: https://forums.developer.apple.com/thread/122048