Introducing RequestCreator protocol #771
Merged
+88
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimdv I think you missed a couple in the websocket tests |
|
Should be fixed! |
kimdv
commented
Sep 20, 2019
| public let originalName: String | ||
| public let mimeType: String | ||
| public let inputStream: InputStream | ||
| public let contentLength: UInt64 |
There was a problem hiding this comment.
Those fields need to be public if users have to make things like
files.forEach {
formData.appendPart(inputStream: $0.inputStream, contentLength: $0.contentLength, name: $0.fieldName, contentType: $0.mimeType, filename: $0.originalName)
}
designatednerd
approved these changes
Sep 21, 2019
|
|
This will ship with 0.16.0 (hopefully early next week)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to modify how requests are created.
Useful in file uploads as the specs can be different from framework to framework