Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPM support #8

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Conversation

dfirsht
Copy link
Contributor

@dfirsht dfirsht commented Oct 18, 2016

No description provided.

@apollo-cla
Copy link

@dfirsht: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@martijnwalraven
Copy link
Contributor

This looks great! Sorry the Travis CI is a bit slow, there seems to be a queue for iOS builds. But the iOS 10 tests have already passed, so the iOS 9 ones should follow soon hopefully.

Have you already started using Apollo iOS with SPM?

@dfirsht
Copy link
Contributor Author

dfirsht commented Oct 18, 2016

Thanks!

I am just starting to play around with it. I was able to get a fetch to the Frontpage-server using Apollo iOS to run successfully using the SPM.

@martijnwalraven martijnwalraven merged commit f6934da into apollographql:master Oct 18, 2016
@martijnwalraven
Copy link
Contributor

Good to hear! Let me know how things go, or if you have any questions or suggestions. Also curious to hear about your use cases. Are you planning on using Apollo iOS in non-Cocoa environments?

@dfirsht
Copy link
Contributor Author

dfirsht commented Oct 19, 2016

Thanks for the quick merge! Right now I am just playing around with it to see what it can do. I was able to integrate Apollo iOS with the Kitura web framework so Kitura can make GraphQL requests on behalf of the client.

Btw SPM requires repos to be tagged with version numbers to be pulled so you'll need to release a new version. It also doesn't recognize the v in front so it will have to be something like 0.3.1

@martijnwalraven
Copy link
Contributor

Ah, good to know! I changed the versioning script to remove the v from the tag and pushed a new version 0.3.1. Let me know if that doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants