Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not lie in comments #4531

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Do not lie in comments #4531

merged 3 commits into from
Nov 24, 2022

Conversation

martinbonnin
Copy link
Contributor

Turns out only settings.gradle.kts have a special handling of pluginManagement {} so we can do listOf(...) here

@netlify
Copy link

netlify bot commented Nov 24, 2022 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit de26dc4
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/637f7d0c33f3fc0009ee625b

BoD
BoD approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@martinbonnin martinbonnin mentioned this pull request Nov 24, 2022
Merged
@martinbonnin martinbonnin merged commit 569f564 into main Nov 24, 2022
@martinbonnin martinbonnin deleted the do-not-lie branch November 24, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@sav007 sav007 Awaiting requested review from sav007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD