Update min version of Kotlin in README and doc #5750
Conversation
…ELOG with 3.x releases
CHANGELOG.md
Outdated
| # Version 3.8.3 | ||
|
|
||
| _2024-03-20_ |
There was a problem hiding this comment.
Do we need to update the changelog in the 3.x branch?
There was a problem hiding this comment.
Tbh it's probably unneeded but while I was here it didn't hurt to do it :)
There was a problem hiding this comment.
What if we change a wording in main? We now have to backport? It's ok to backport for code but for changelog, I'd rather have only a single source of truth.
There was a problem hiding this comment.
Fair enough - I reverted
| * Kotlin 1.8+ for JVM projects | ||
| * Kotlin 1.9+ for native projects |
There was a problem hiding this comment.
Are we sure native doesn't work with 1.8 these days?
There was a problem hiding this comment.
Looks like not, I can't build a project with 1.8.22 with:
w: skipping /Users/bod/.gradle/caches/modules-2/files-2.1/com.apollographql.apollo3/apollo-normalized-cache-sqlite-macosarm64/3.8.3/689b3b4527baf866a88cb0559ef1772c7b8216c7/apollo-normalized-cache-sqlite.klib. Incompatible abi version. The current default is '1.7.0', found '1.8.0'. The library produced by 1.9.20 compiler
e: Could not find "/Users/bod/.gradle/caches/modules-2/files-2.1/com.apollographql.apollo3/apollo-normalized-cache-sqlite-macosarm64/3.8.3/689b3b4527baf866a88cb0559ef1772c7b8216c7/apollo-normalized-cache-sqlite.klib" in [/Users/bod/gitrepo/apollo-kotlin-template-mpp, /Users/bod/.konan/klib, /Users/bod/.konan/kotlin-native-prebuilt-macos-aarch64-1.8.22/klib/common, /Users/bod/.konan/kotlin-native-prebuilt-macos-aarch64-1.8.22/klib/platform/macos_arm64]
Although I'm a bit confused by the "1.7.0" mention in the message.
There was a problem hiding this comment.
I opened https://youtrack.jetbrains.com/issue/KT-66755/Native-add-support-for-languageVersion to try to understand this better.
LGTM in all cases. Let's ask for 1.9 since we know this will work. K/N consumers are probably already on 1.9 anyways.
…ios12-compat * commit 'b8e8bdba951b1cb9beecabfc80433d848b2c921b': (38 commits) release 3.8.5 Fix mapping of the builtin Float scalar type (apollographql#6047) SqlNormalizedCacheFactory make sqldriver public to support Sqlcipher data encryption. (apollographql#5972) Update 08-add-a-details-view.mdx for additional state handling (apollographql#5975) adding checks for json end_document in http batching interceptors (apollographql#5892) adding checks for json end_document in http transport (apollographql#5894) [3.x] Bump okio to 3.9.0 (apollographql#5868) version is now 3.8.5-SNAPSHOT release 3.8.4 Backport apollographql#5848 to the v3 branch (apollographql#5863) Backport apollographql#5840 to the v3 branch (apollographql#5861) Backport apollographql#5778 to the v3 branch (apollographql#5860) Update min version of Kotlin in README and doc (apollographql#5750) version is now 3.8.4-SNAPSHOT release 3.8.3 Add deprecations on symbols that are getting removed in v4 (apollographql#5746) docs: Correct file name discrepancies in tutorial documentation (apollographql#5740) Ignore IOException when calling ApolloHttpCache.remove (apollographql#5730) Added an implementation of a missing NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a web socket to successfully reopen. (apollographql#5704) Update plugin-configuration.mdx (apollographql#5673) ... # Conflicts: # gradle.properties # libraries/apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/network/ws/NSURLSessionWebSocketEngine.kt
Also update the changelog with all 3.x versions